Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onnx.If #2825

Merged
merged 17 commits into from
Apr 30, 2024
Merged

Support onnx.If #2825

merged 17 commits into from
Apr 30, 2024

Conversation

renxida
Copy link
Collaborator

@renxida renxida commented Jan 29, 2024

This is probably a decent PR for learning about blocks and regions.

If you're here to learn about that, consider also looking at lib/Conversion/TorchToSCF/TorchToSCF.cpp

While this doesn't include an e2e test, it is tested downstream in https://github.com/nod-ai/SHARK-TestSuite/blob/main/e2eshark/onnx/operators/If/model.py

@renxida renxida force-pushed the onnx-control-flow branch from 5fd7053 to bb3bf75 Compare April 1, 2024 18:48
@renxida renxida force-pushed the onnx-control-flow branch from bb3bf75 to 1228fd8 Compare April 8, 2024 19:41
@renxida renxida changed the title Support onnx.If and onnx.Loop Support onnx.If Apr 18, 2024
@renxida renxida marked this pull request as ready for review April 18, 2024 21:41
@renxida renxida requested a review from rsuderman April 19, 2024 00:20
@renxida renxida self-assigned this Apr 19, 2024
@renxida renxida enabled auto-merge (squash) April 30, 2024 17:42
@renxida renxida merged commit 33eef15 into llvm:main Apr 30, 2024
3 checks passed
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
This is probably a decent PR for learning about blocks and regions.

If you're here to learn about that, consider also looking at
lib/Conversion/TorchToSCF/TorchToSCF.cpp

While this doesn't include an e2e test, it is tested downstream in
https://github.com/nod-ai/SHARK-TestSuite/blob/main/e2eshark/onnx/operators/If/model.py

---------

Co-authored-by: Xida Ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants